feat(frontend): pool switcher and pool-scoped titles for logs and compute - #5499
Conversation
|
Stack for rivet-dev/rivet
Get stack: change xwmxvxvp |
Review: pool switcher and pool-scoped titles for logs and computeNice feature, and the Ladle story choices (integration unit with the title, realistic fixtures like the no- Two issues from the previous pass on this PR are now fixed:
Open findingThe conditional validateSearch: (search) => {
const validated = searchSchema.parse(search);
if (validated.settings !== "compute") {
delete (validated as { pool?: string }).pool;
}
return validated;
},The comment says this scopes
I can't spin up the dev server in this sandbox to confirm the exact chaining behavior empirically, but the logic as written doesn't match the stated intent regardless: it should preserve Minor
No security or backend concerns. This PR is frontend-only (routing/state/UI), and |
|
🚅 Deployed to the rivet-pr-5499 environment in rivet-frontend
|
3220ea4 to
289ca6e
Compare
919f407 to
d81fef1
Compare
d81fef1 to
02e7183
Compare
No description provided.