Add option to highlight entire selected row of a List item#220
Add option to highlight entire selected row of a List item#220rivo merged 3 commits intorivo:masterfrom
Conversation
|
Generally ok with this. But could you please rename the member variable (and the function accordingly) to GitHub says there are merge conflicts. You might want to pull in the latest changes before resubmitting. |
|
You know, I've been thinking about this some more and I think this should not be the default. It will look quite odd on very wide screens with little text on a line. So I think this should be called |
|
Do you still want to make the proposed change? (It seems that you'll need to resolve a merge conflict, too, as the file has changed in the meantime.) |
|
finally resolved conflict and updated the field name as requested, please pull when ready |
Yeah, I suppose in that case it might look odd. Is that really the most common case though? To me it seems like the current implementation diverges from widespread convention. I can't think of any list in any application where only the text is highlighted (all context menus, dropdown menus, list boxes, combo boxes in macOS, Windows, Gnome, and KDE; all list controls in Chrome and Firefox). I realize these are graphical applications, but why would the convention be any different? EDIT: |
|
I don't know. I just tried it on But if there are actual complaints from more users, I'm willing to rethink this. |
This implements the option requested in #219