Call the selected function on manual select#256
Closed
urandom wants to merge 1 commit intorivo:masterfrom
Closed
Conversation
On SetCurrentOption, call the main selected function if set, as well as the option's selected function, if set.
Owner
|
Thanks for the PR. I started to write some feedback and request some changes but it turns out the handling I'm envisioning for this required quite a bit more work, especially the function comments should be adapted accordingly. So I've gone ahead and made the change myself. Please see the referenced commit. |
Bios-Marcel
pushed a commit
to Bios-Marcel/tview
that referenced
this pull request
Jul 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On SetCurrentOption, call the main selected function if set, as well as
the option's selected function, if set.