Sleep presentation TextView1 example when inactive#319
Merged
rivo merged 4 commits intorivo:masterfrom Feb 19, 2020
ajcarvajal:master
Merged
Sleep presentation TextView1 example when inactive#319rivo merged 4 commits intorivo:masterfrom ajcarvajal:master
rivo merged 4 commits intorivo:masterfrom
ajcarvajal:master
Conversation
Owner
|
The demo presentation was never meant to be run for a longer time so I'm not sure this is a real problem. But it's ok. I'll merge your commit if you exclude the "formatting fixes" in treeview.go. (I'd like to keep it brief to provide a good overview and gofmt is still fine with it.) |
This reverts commit e4b4b7f.
Contributor
Author
|
Cool, didn't mean to include the formatting changes anyway. Thanks for taking a look. I'm trying to get involved as a new dev, so it's appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A goroutine in the demo presentation increments an integer infinitely in the background. Now checks hasFocus() and sleeps longer if inactive