Closed
Conversation
when a changed function is set, deleting the first element (0-index) lead to a index out of range error. Now the index will only be decreased if the last item was removed. That changes the behaviour of the selection slightly: It will stay at the same place and only move up when the last item was removed.
Contributor
Author
|
Hi, any optinions on this? It is a two lines fix after all :) Regards |
|
Hello. Best regards. |
Owner
|
The latest commit should fix this. If you want issues like this to be resolved sooner (or at all), please read the Contributing Guidelines, specifically the section about opening an issue before submitting a pull request. (Especially since the proposed solution of this PR would have introduced more bugs.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a changed function is set, deleting the first element (0-index) lead to a index out of range error because the change event was fired with index = -1.
Now the index will only be decreased if the last item was removed. As a side effect that changes the behavior of the selection slightly:
It will stay at the same place and only move up when the last item was removed.