fix remove dropdown option index out of range#927
Closed
7yyo wants to merge 2 commits intorivo:masterfrom
Closed
Conversation
Owner
|
Thanks for catching this. Two things needed to be done here:
I ended up making these changes myself. I hope you don't mind. |
kopecmaciej
pushed a commit
to kopecmaciej/tview
that referenced
this pull request
Aug 27, 2024
…oved in its callback. Fixes rivo#927
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rivo
Hi, when setSelectFunc of dropdown to remove current option, if the last option is selected, index out of range will panic. I tried to fix this bug.
The code below will reproduce this bug if select the last option
Fifth.