Skip to content

[pull] main from twbs:main#272

Merged
pull[bot] merged 12 commits intorizalgowandy:mainfrom
twbs:main
Mar 23, 2021
Merged

[pull] main from twbs:main#272
pull[bot] merged 12 commits intorizalgowandy:mainfrom
twbs:main

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented Mar 23, 2021

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

GeoSot and others added 2 commits March 23, 2021 08:22
* Update docs to use new .show behavior and clarify some copy for first example

Co-authored-by: Mark Otto <markdotto@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
@pull pull Bot added the ⤵️ pull label Mar 23, 2021
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 23, 2021

Pull Request Test Coverage Report for Build 680360912

  • 17 of 19 (89.47%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 94.899%

Changes Missing Coverage Covered Lines Changed/Added Lines %
js/src/dropdown.js 9 11 81.82%
Files with Coverage Reduction New Missed Lines %
js/src/dropdown.js 1 92.93%
Totals Coverage Status
Change from base Build 678347752: 0.2%
Covered Lines: 2060
Relevant Lines: 2123

💛 - Coveralls

dependabot Bot and others added 10 commits March 23, 2021 14:53
Bumps [clean-css-cli](https://github.com/jakubpawlowicz/clean-css-cli) from 5.2.1 to 5.2.2.
- [Release notes](https://github.com/jakubpawlowicz/clean-css-cli/releases)
- [Changelog](https://github.com/jakubpawlowicz/clean-css-cli/blob/master/History.md)
- [Commits](clean-css/clean-css-cli@v5.2.1...v5.2.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [rollup](https://github.com/rollup/rollup) from 2.41.3 to 2.42.3.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.41.3...v2.42.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Bumps [globby](https://github.com/sindresorhus/globby) from 11.0.2 to 11.0.3.
- [Release notes](https://github.com/sindresorhus/globby/releases)
- [Commits](sindresorhus/globby@v11.0.2...v11.0.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Bumps [hugo-bin](https://github.com/fenneclab/hugo-bin) from 0.69.0 to 0.70.0.
- [Release notes](https://github.com/fenneclab/hugo-bin/releases)
- [Commits](fenneclab/hugo-bin@v0.69.0...v0.70.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
* Bump eslint-plugin-unicorn from 28.0.2 to 29.0.0

Bumps [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn) from 28.0.2 to 29.0.0.
- [Release notes](https://github.com/sindresorhus/eslint-plugin-unicorn/releases)
- [Commits](sindresorhus/eslint-plugin-unicorn@v28.0.2...v29.0.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Fix lint failure

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
* remove stopPropagation from button click event

* test for delegated click events

* ensure button children can open menu

* test to ensure clicking button opens the menu

* check current element and parents

* allow dropdown form click events to bubble
@pull pull Bot merged commit 232e392 into rizalgowandy:main Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants