Skip to content

Comments

Move initialization of all crypto search methods to the add() function.#5002

Merged
wargio merged 1 commit intorizinorg:devfrom
Rot127:crypto-add
Mar 15, 2025
Merged

Move initialization of all crypto search methods to the add() function.#5002
wargio merged 1 commit intorizinorg:devfrom
Rot127:crypto-add

Conversation

@Rot127
Copy link
Member

@Rot127 Rot127 commented Mar 15, 2025

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).

Detailed description

Adding search methods in the initialization function would delude the consistency of the design.
Meaning: After initialization of the any collection, it is expected to be empty. Search methods have to be added in a separated step.

Test plan

All green

Closing issues

...

@wargio wargio merged commit bffac77 into rizinorg:dev Mar 15, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants