Merged
Conversation
Reduces vertical space usage by placing the breadcrumb navigation and Adjust button in a shared toolbar row instead of separate rows. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move the mobile menu button from browse-mode header into each viewer's toolbar. The browse-mode viewer-header now only appears when no file is selected. This prevents showing both a path and breadcrumb redundantly on mobile devices. Changes: - BrowseMode: conditional viewer-header, pass onMobileMenuClick to viewers - All viewers: add mobile menu button to toolbar/header - MarkdownViewer: fix empty state check to use currentPath instead of currentFileContent so breadcrumb shows immediately when file selected Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move Save/Cancel buttons into the toolbar alongside breadcrumb in adjust mode for MarkdownViewer, TxtViewer, and JsonViewer. This ensures consistent layout between normal and adjust modes, and includes the mobile menu button in adjust mode. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When a file path has more than 3 segments, the breadcrumb now shows: Root / … / parent / file.md Tapping the ellipsis (…) expands to show the full path. The collapsed state resets when navigating to a different file. Applied to all viewers: MarkdownViewer, TxtViewer, JsonViewer, CsvViewer. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
On mobile, the header now starts collapsed showing only a logo button next to the toolbar. Tapping the logo expands to show the full header (app title, vault name, settings, version). Tapping the title collapses it again. This reclaims two rows of vertical space on mobile by default while keeping all header functionality accessible. Desktop layout is unchanged (always shows full header). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Cover the new mobile menu button functionality and collapsible breadcrumb behavior added in this PR. - JsonViewer: empty/loading/error states, JSON rendering, breadcrumb navigation, collapsible breadcrumb, mobile menu button, adjust mode - PdfViewer: basic rendering, download button, fallback, mobile menu - VideoViewer: rendering, loading/error states, path changes, mobile menu Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root / … / parent / file.mdwith tap-to-expandTest plan
Root / … / parent / file.md…to expand full breadcrumb path🤖 Generated with Claude Code