Skip to content

feat: mobile screen space optimizations #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjroy merged 7 commits into from
Jan 18, 2026
Merged

feat: mobile screen space optimizations #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0aaf3d7
feat: combine breadcrumb and Adjust button on same row
rjroy Jan 18, 2026
9bdaa1d
fix: eliminate duplicate path display on mobile
rjroy Jan 18, 2026
01c4a39
fix: unify adjust mode toolbar with normal view
rjroy Jan 18, 2026
b4f6317
feat: collapse long breadcrumb paths on mobile
rjroy Jan 18, 2026
6db39d0
feat: collapsible header on mobile
rjroy Jan 18, 2026
01f0863
feat: change markdown viewer content wrapper from div to article
rjroy Jan 18, 2026
adce5f8
test: add tests for JsonViewer, PdfViewer, and VideoViewer
rjroy Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions frontend/src/App.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,78 @@
}
}

/* Mobile header collapse button - hidden by default */
.app-header__collapse-btn {
display: none;
align-items: center;
justify-content: center;
width: 44px;
height: 44px;
min-width: 44px;
padding: 0;
background: transparent;
border: 1px solid transparent;
border-radius: var(--radius-md);
cursor: pointer;
transition: background-color 0.2s ease, border-color 0.2s ease;
}

.app-header__collapse-btn:hover {
background: var(--color-accent-primary-a10);
border-color: var(--glass-border);
}

@media (hover: none) {
.app-header__collapse-btn:hover {
background: transparent;
border-color: transparent;
}
}

.app-header__collapse-btn .app-logo {
width: 32px;
height: 32px;
}

/* Title button for collapsing (mobile only) */
.app-title-btn {
background: transparent;
border: none;
padding: 0;
margin: 0;
cursor: pointer;
display: contents;
}

/* Mobile collapsed state */
@media (max-width: 767px) {
.app-header--collapsed {
flex-wrap: nowrap;
justify-content: flex-start;
}

.app-header--collapsed .app-header__collapse-btn {
display: flex;
}

.app-header--collapsed .app-header__left,
.app-header--collapsed .app-header__right {
display: none;
}

.app-header--collapsed .app-header__center {
order: 0;
width: auto;
flex: 1;
justify-content: flex-start;
}

/* Expanded state on mobile */
.app-header--expanded .app-header__collapse-btn {
display: none;
}
}

.app-header__left {
display: flex;
flex-direction: column;
Expand Down
32 changes: 30 additions & 2 deletions frontend/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ function MainContent(): React.ReactNode {
const [toastVariant, setToastVariant] = useState<ToastVariant>("success");
const [toastMessage, setToastMessage] = useState("");
const holiday = useHoliday();
// Mobile header collapse state
const [isHeaderCollapsed, setIsHeaderCollapsed] = useState(true);

// Process server messages through the session handler
useEffect(() => {
Expand Down Expand Up @@ -128,13 +130,39 @@ function MainContent(): React.ReactNode {
setToastVisible(false);
}

const headerClassName = isHeaderCollapsed
? "app-header app-header--collapsed"
: "app-header app-header--expanded";

function handleHeaderToggle() {
setIsHeaderCollapsed((prev) => !prev);
}

return (
<>
<header className="app-header">
<header className={headerClassName}>
{/* Collapsed mobile view: logo button + toolbar */}
<button
type="button"
className="app-header__collapse-btn"
onClick={handleHeaderToggle}
aria-label={isHeaderCollapsed ? "Expand header" : "Collapse header"}
aria-expanded={!isHeaderCollapsed}
>
<img src={logoSrc} alt="" className="app-logo" aria-hidden="true" />
</button>

<div className="app-header__left">
<div className="app-title-row">
<img src={logoSrc} alt="" className="app-logo" aria-hidden="true" />
<h1 className="app-title">Memory Loop</h1>
<button
type="button"
className="app-title-btn"
onClick={handleHeaderToggle}
aria-label="Collapse header"
>
<h1 className="app-title">Memory Loop</h1>
</button>
</div>
{vault && (
<div className="app-vault-row">
Expand Down
40 changes: 40 additions & 0 deletions frontend/src/components/BrowseMode.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,42 @@
}
}

/* Mobile menu button in viewer toolbars - hidden on desktop */
.viewer-mobile-menu-btn {
display: none;
align-items: center;
justify-content: center;
width: 44px;
height: 44px;
padding: 0;
background: transparent;
border: 1px solid transparent;
border-radius: var(--radius-md);
color: var(--color-text);
cursor: pointer;
flex-shrink: 0;
transition: background-color 0.2s ease, border-color 0.2s ease, box-shadow 0.3s ease;
}

.viewer-mobile-menu-btn:hover {
background: var(--color-accent-primary-a10);
border-color: var(--glass-border);
box-shadow: 0 0 12px var(--color-accent-primary-a15);
}

@media (hover: none) {
.viewer-mobile-menu-btn:hover {
background: transparent;
border-color: transparent;
box-shadow: none;
}
}

.viewer-mobile-menu-btn__icon {
width: 20px;
height: 20px;
}

.browse-mode__current-file {
flex: 1;
font-size: var(--text-sm);
Expand Down Expand Up @@ -435,6 +471,10 @@
display: flex;
}

.viewer-mobile-menu-btn {
display: flex;
}

.browse-mode__overlay {
display: block;
}
Expand Down
45 changes: 24 additions & 21 deletions frontend/src/components/BrowseMode.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,36 +790,39 @@ export function BrowseMode(): React.ReactNode {

{/* Viewer pane */}
<main className="browse-mode__viewer-pane">
<div className="browse-mode__viewer-header">
<button
type="button"
className="browse-mode__mobile-menu-btn"
onClick={toggleMobileTree}
aria-label="Open file browser"
>
<MenuIcon />
</button>
<span className="browse-mode__current-file">
{browser.currentPath || "No file selected"}
</span>
</div>
{/* Mobile header - only shown when no file is selected */}
{!browser.currentPath && (
<div className="browse-mode__viewer-header">
<button
type="button"
className="browse-mode__mobile-menu-btn"
onClick={toggleMobileTree}
aria-label="Open file browser"
>
<MenuIcon />
</button>
<span className="browse-mode__current-file">
No file selected
</span>
</div>
)}
<article className="browse-mode__viewer-content">
{isImageFile(browser.currentPath) ? (
<ImageViewer path={browser.currentPath} assetBaseUrl={assetBaseUrl} />
<ImageViewer path={browser.currentPath} assetBaseUrl={assetBaseUrl} onMobileMenuClick={toggleMobileTree} />
) : isVideoFile(browser.currentPath) ? (
<VideoViewer path={browser.currentPath} assetBaseUrl={assetBaseUrl} />
<VideoViewer path={browser.currentPath} assetBaseUrl={assetBaseUrl} onMobileMenuClick={toggleMobileTree} />
) : isPdfFile(browser.currentPath) ? (
<PdfViewer path={browser.currentPath} assetBaseUrl={assetBaseUrl} />
<PdfViewer path={browser.currentPath} assetBaseUrl={assetBaseUrl} onMobileMenuClick={toggleMobileTree} />
) : isJsonFile(browser.currentPath) ? (
<JsonViewer onNavigate={handleNavigate} onSave={handleSave} />
<JsonViewer onNavigate={handleNavigate} onSave={handleSave} onMobileMenuClick={toggleMobileTree} />
) : isTxtFile(browser.currentPath) ? (
<TxtViewer onNavigate={handleNavigate} onSave={handleSave} />
<TxtViewer onNavigate={handleNavigate} onSave={handleSave} onMobileMenuClick={toggleMobileTree} />
) : isCsvFile(browser.currentPath) ? (
<CsvViewer onNavigate={handleNavigate} />
<CsvViewer onNavigate={handleNavigate} onMobileMenuClick={toggleMobileTree} />
) : isMarkdownFile(browser.currentPath) || !browser.currentPath ? (
<MarkdownViewer onNavigate={handleNavigate} assetBaseUrl={assetBaseUrl} onSave={handleSave} />
<MarkdownViewer onNavigate={handleNavigate} assetBaseUrl={assetBaseUrl} onSave={handleSave} onMobileMenuClick={toggleMobileTree} />
) : (
<DownloadViewer path={browser.currentPath} assetBaseUrl={assetBaseUrl} />
<DownloadViewer path={browser.currentPath} assetBaseUrl={assetBaseUrl} onMobileMenuClick={toggleMobileTree} />
)}
</article>
{/* Recall Widgets - collapsible panel shown when viewing files that match widget source patterns */}
Expand Down
57 changes: 55 additions & 2 deletions frontend/src/components/CsvViewer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,22 +23,50 @@
overflow-y: auto;
}

/* Toolbar with breadcrumb */
.csv-viewer__toolbar {
display: flex;
align-items: center;
gap: var(--spacing-sm);
padding: var(--spacing-xs) var(--spacing-md);
background: var(--glass-bg-quartary);
backdrop-filter: blur(var(--glass-blur));
border-bottom: 1px solid var(--glass-border);
min-height: 44px;
}

@supports not (backdrop-filter: blur(10px)) {
.csv-viewer__toolbar {
background-color: var(--color-surface);
}
}

/* Breadcrumb navigation */
.csv-viewer__breadcrumb {
display: flex;
align-items: center;
flex-wrap: wrap;
flex: 1;
min-width: 0;
gap: var(--spacing-xs);
font-size: var(--text-sm);
}

/* Standalone breadcrumb (loading/error/parse-error states) */
.csv-viewer--loading .csv-viewer__breadcrumb,
.csv-viewer--error .csv-viewer__breadcrumb,
.csv-viewer--parse-error .csv-viewer__breadcrumb {
padding: var(--spacing-sm) var(--spacing-md);
background: var(--glass-bg-quartary);
backdrop-filter: blur(var(--glass-blur));
border-bottom: 1px solid var(--glass-border);
font-size: var(--text-sm);
min-height: 44px;
}

@supports not (backdrop-filter: blur(10px)) {
.csv-viewer__breadcrumb {
.csv-viewer--loading .csv-viewer__breadcrumb,
.csv-viewer--error .csv-viewer__breadcrumb,
.csv-viewer--parse-error .csv-viewer__breadcrumb {
background-color: var(--color-surface);
}
}
Expand Down Expand Up @@ -76,6 +104,31 @@
font-weight: var(--font-medium);
}

.csv-viewer__breadcrumb-ellipsis {
background: transparent;
border: 1px solid transparent;
padding: var(--spacing-xs) var(--spacing-sm);
color: var(--color-text-secondary);
cursor: pointer;
border-radius: var(--radius-md);
font-size: var(--text-sm);
transition: background-color 0.2s ease, border-color 0.2s ease, color 0.2s ease;
}

.csv-viewer__breadcrumb-ellipsis:hover {
background: var(--color-accent-primary-a10);
border-color: var(--glass-border);
color: var(--color-text-accent);
}

@media (hover: none) {
.csv-viewer__breadcrumb-ellipsis:hover {
background: transparent;
border-color: transparent;
color: var(--color-text-secondary);
}
}

/* Warning banner (for truncation, parse warnings) */
.csv-viewer__warning {
padding: var(--spacing-sm) var(--spacing-md);
Expand Down
Loading