Skip to content

fix: Remove arbitrary 12-character limit on AskUserQuestion header#450

Merged
rjroy merged 1 commit intomainfrom
fix/ask-user-q-6wi7v
Feb 3, 2026
Merged

fix: Remove arbitrary 12-character limit on AskUserQuestion header#450
rjroy merged 1 commit intomainfrom
fix/ask-user-q-6wi7v

Conversation

@rjroy
Copy link
Copy Markdown
Owner

@rjroy rjroy commented Feb 3, 2026

Summary

  • Removes the max(12) validation on AskUserQuestion header field that was rejecting valid headers like "Image extraction"
  • Claude Code suggests 12 chars but doesn't enforce it, so our validation was overly strict
  • Also fixes vault-setup test that expected outdated content ("Quick focused" vs "Quick, focused")

Test plan

  • Shared protocol tests pass (90 tests)
  • Full backend test suite passes (2566 tests)
  • Headers longer than 12 characters now accepted

🤖 Generated with Claude Code

The header field validation was rejecting valid headers like "Image extraction"
(16 chars). Claude Code's tool definition suggests 12 chars but doesn't enforce
it, so this validation was overly strict.

Also fixes vault-setup test that expected outdated content after daily-debrief
command was updated.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@rjroy rjroy merged commit 4aae4db into main Feb 3, 2026
2 checks passed
@rjroy rjroy deleted the fix/ask-user-q-6wi7v branch February 3, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant