Skip to content

fix: Remove arbitrary 12-character limit on AskUserQuestion header #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjroy merged 1 commit into from
Feb 3, 2026
Merged

fix: Remove arbitrary 12-character limit on AskUserQuestion header #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/__tests__/vault-setup.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ describe("installCommands", () => {
// Verify custom file was replaced with server version
const content = await readFile(join(commandsDir, "daily-debrief.md"), "utf-8");
expect(content).not.toBe(customContent);
expect(content).toContain("Quick focused conversation"); // Should have the real content
expect(content).toContain("Quick, focused conversation"); // Should have the real content
});

test("reports mixed installed and updated files", async () => {
Expand Down
14 changes: 0 additions & 14 deletions shared/src/__tests__/protocol.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,20 +1182,6 @@ describe("AskUserQuestion Schemas", () => {
expect(result.options).toHaveLength(2);
});

test("rejects header longer than 12 characters", () => {
const longHeader = {
question: "Question?",
header: "VeryLongHeader",
options: [
{ label: "A", description: "Option A" },
{ label: "B", description: "Option B" },
],
multiSelect: false,
};

expect(() => AskUserQuestionItemSchema.parse(longHeader)).toThrow(ZodError);
});

test("rejects less than 2 options", () => {
const tooFewOptions = {
question: "Question?",
Expand Down
4 changes: 2 additions & 2 deletions shared/src/protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,8 +486,8 @@ export const AskUserQuestionOptionSchema = z.object({
export const AskUserQuestionItemSchema = z.object({
/** The full question text to display */
question: z.string().min(1, "Question text is required"),
/** Short label for the question (max 12 chars) */
header: z.string().max(12, "Header must be 12 characters or less"),
/** Short label for the question */
header: z.string().min(1, "Header is required"),
/** Available choices (2-4 options) */
options: z.array(AskUserQuestionOptionSchema).min(2).max(4),
/** If true, users can select multiple options */
Expand Down