chore: migrate to Charm v2 ecosystem#114
Conversation
Migrated project dependencies from `github.com/charmbracelet/*` to the new `charm.land/*` v2 modules. Updated UI component implementations to accommodate breaking API changes in Bubble Tea v2, bubbles v2, and lipgloss v2.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Code Review
This pull request migrates the project to the v2 versions of the Charm libraries (Bubble Tea, Bubbles, Lip Gloss, Huh, and Glamour), which are now hosted at charm.land. The changes include updating import paths, adapting to API shifts such as the transition from tea.KeyMsg to tea.KeyPressMsg, and updating View methods to return the tea.View type. Review feedback suggests resolving a FIXME regarding textarea styling and removing speculative comments from the UI logic.
Coverage Report for CI Build 26398157823Warning No base build found for commit Coverage: 33.777%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
- Disable `CursorLine` styling in the `textarea` to match v1 UI behavior. - Remove stale, unused comments regarding `tea.View` concatenation.
- Update `TestModel_Update` mock assertion to match exact key sequence. - Use `ansi.Strip` to ensure spinner message assertions ignore ANSI escape sequences, preventing failures due to styling.
…t/diff-view * 'main' of github.com:rm-hull/git-commit-summary: fix: streamline summary generation with persistent hints (#116) fix: re-enable help text when cancelling regeneration (#115) chore: migrate to Charm v2 ecosystem (#114) chore: update download stats [skip ci] chore: go get -u && go mod tidy (#113)
Migrated project dependencies from
github.com/charmbracelet/*to the newcharm.land/*v2 modules. Updated UI component implementations to accommodate breaking API changes in Bubble Tea v2, bubbles v2, and lipgloss v2.