fix: re-enable help text when cancelling regeneration#115
Merged
Conversation
Ensure that `helpText` is visible when returning to the commit view from the regeneration prompt state.
Contributor
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Coverage Report for CI Build 26399062350Coverage increased (+0.06%) to 33.835%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Code Review
This pull request ensures that help text is re-enabled when the commit view is initialized, specifically after cancelling a prompt regeneration. The unit tests were updated to verify this state change using a real model instead of a mock. Feedback suggests simplifying the test setup by using the existing initialModel helper and adding an assertion to verify that the command returned by the update function is correctly propagated.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Update the Update method to return a command.
rm-hull
added a commit
that referenced
this pull request
May 25, 2026
…t/diff-view * 'main' of github.com:rm-hull/git-commit-summary: fix: streamline summary generation with persistent hints (#116) fix: re-enable help text when cancelling regeneration (#115) chore: migrate to Charm v2 ecosystem (#114) chore: update download stats [skip ci] chore: go get -u && go mod tidy (#113)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that
helpTextis visible when returning to the commit view from the regeneration prompt state.