Skip to content

Conversation

@dd32
Copy link
Member

@dd32 dd32 commented Dec 13, 2017

This PR combines the effort from #298, #280, and #302 and fixes the final few issues affecting the build.

For the background on what this PR actually contains, please see #302 (comment)

@dd32
Copy link
Member Author

dd32 commented Dec 13, 2017

The PHP 5.3 build failed due to what looks like the test server failing to boot up and just needs a restart.

Copy link
Collaborator

@rmccue rmccue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restarted the job and we're good to go. Thanks @dd32, @ntwb and @ozh for all your work on this! 🙌 ✨

@rmccue rmccue merged commit 4055bc4 into WordPress:master Dec 13, 2017
@ntwb
Copy link
Member

ntwb commented Dec 13, 2017

Awesome, thanks y'all 💯

@ozh
Copy link
Collaborator

ozh commented Dec 13, 2017

\o/

@jrfnl jrfnl added this to the 1.7.1 milestone Sep 17, 2019
@jrfnl jrfnl mentioned this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants