refactor(moe): MoeRouter rename + finish Codecov (#14) - #24
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR renames the public MoE router and output types, updates tests and README examples, and adds Codecov configuration, a coverage badge, and LCOV artifact exclusion. ChangesMoE Router API Rename
Coverage Reporting Configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
✨ Simplify code
Comment |
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR successfully completes the refactoring to make the MoE router API family-agnostic by renaming OlmoeRouter → MoeRouter and OlmoeOutput → MoeOutput. The changes are consistent across documentation, code, and tests. The Codecov configuration additions (badge, ignore paths, gitignore) properly address issue #14 requirements. All changes compile correctly and maintain backward compatibility at the metadata layer as documented in the PR description.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Qodana for RustIt seems all right 👌 No new problems were found according to the checks applied ☁️ View the detailed Qodana report Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58f0aea356
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov expects `ignore` at the YAML root, not nested under `coverage`. Addresses Codex review on PR #24. Grok Build: Grok 4.5
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
coderabbitai
Bot
added
documentation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 198-211: Wrap the README MoE example containing
MoeRouter::load_with_mode and router.forward in a fn main() ->
cortex_tensor::Result<()> function, and return Ok(()) after the existing
operations so the ? operators compile unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 63cd65ce-ef60-45c8-85b3-62d792ce86d1
📒 Files selected for processing (5)
.gitignoreREADME.mdcodecov.ymlsrc/moe/mod.rssrc/moe/tests.rs
|
Babysit note (Grok Build: Grok 4.5)
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Replace family-branded OlmoeRouter/OlmoeOutput with generic MoeRouter/MoeOutput so the public API matches multi-family MoE support. ModelFamily::Olmoe and GGUF olmoe.* metadata keys are unchanged. Complete remaining issue #14 acceptance items: Codecov README badge, top-level ignore paths in codecov.yml (target/**, examples/**), and local lcov.info gitignore. README MoE example uses a Result-returning main so `?` is valid. Implemented by Grok Build: Grok 4.5 Closes #14
45064bb to
962a839
Compare
There was a problem hiding this comment.
Our agent can fix these. Install it.
Gates Passed
Absence of Expected Change Pattern
- cortex-tensor/src/moe/mod.rs is usually changed with: cortex-tensor/src/moe/checkpoint.rs
Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
1 participant
Summary
OlmoeRouter→MoeRouterandOlmoeOutput→MoeOutputso the API is family-agnostic (supports OLMoE, Qwen3-MoE, Gemma-4, DeepSeek-2, Llama-MoE).codecov.ymlignore paths, locallcov.infogitignore.ModelFamily::Olmoeand GGUFolmoe.*metadata keys are unchanged (they name a real architecture, not the router type). No deprecated type aliases (crate is0.1.0; no external consumers found).Core Codecov CI (
cargo llvm-cov+ conditional upload) was already onmain; this PR only closes the remaining gaps.Closes #14
Test plan
cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test --locked(36 tests)CODECOV_TOKENpresent)OlmoeRouter/OlmoeOutputsymbolsImplemented by Grok Build: Grok 4.5
Summary by cubic
Renamed
OlmoeRouter/OlmoeOutputtoMoeRouter/MoeOutputfor a family-agnostic API, finished Codecov setup, and fixed the README MoE example so it compiles.OlmoeRouter→MoeRouter,OlmoeOutput→MoeOutput; keepModelFamily::Olmoeand GGUFolmoe.*unchanged.fn main() -> cortex_tensor::Result<()>).ignoreincodecov.yml(target/**,examples/**); ignore locallcov.infoin.gitignore.MoeRouterandMoeOutput.MoeRouter::load_with_mode(...).Written for commit 45064bb. Summary will update on new commits.