Restrict dashboard schema selection - #5688
Open
ydah wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphQL::Dashboardcurrently resolves theschemaquery parameter before the schema configured at mount time and callsconstantizeon any string value. A request such as? schema=Kernelcan therefore trigger arbitrary constant resolution, causing repeatedNameErrorexceptions and potentially exposing information about constants in the application.This also means that
mount GraphQL::Dashboard, schema: "MySchema"does not reliably enforce the configured schema because the query parameter can override it.The mount-time schema configuration is now treated as trusted configuration. Query parameters are only accepted when they match one of the configured schemas, and unknown values fall back to the configured default schema.
This prevents arbitrary constantization while preserving the intended mount configuration. Tests cover both allowed schema selection and rejected arbitrary values.