Restrict subscription timestamp deserialization - #5691
Open
ydah wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents arbitrary constant resolution during subscription payload deserialization.
Previously, timestamp payloads used
Object.const_getto resolve the class name and then calledstrptimeon it. If an untrusted payload reached this code path, it could invoke methods on an arbitrary top-level class.Timestamp deserialization is now restricted to
Date,DateTime,Time, andActiveSupport::TimeWithZonewhen available. Unsupported classes raiseArgumentError.A regression test verifies that
strptimeis not invoked on arbitrary classes.