fix(compose): make dev compose environment variables overridable - #450
Closed
MS-Jahan wants to merge 1 commit into
Closed
fix(compose): make dev compose environment variables overridable#450MS-Jahan wants to merge 1 commit into
MS-Jahan wants to merge 1 commit into
Conversation
The dev compose hardcoded most environment variables to fixed values,
so operators couldn't override them from the environment / .env without
editing the file. Convert user-facing settings to the ${VAR:-default}
pattern (keeping the same defaults), matching the production compose.
This includes the data-path settings that are documented in .env.example
(SESSION_DATA_PATH, STORAGE_LOCAL_PATH) — defaults stay under /app/data
(the ./data bind mount) so persistence is unchanged out of the box.
Truly container-internal values (HOME, XDG_*, PORT) stay fixed: they
must match the image/entrypoint, so they are intentionally not
parameterized — same convention as docker-compose.yml.
Co-authored-by: Cursor <cursoragent@cursor.com>
MS-Jahan
force-pushed
the
fix/dev-compose-overridable-env
branch
from
June 23, 2026 16:33
68872e8 to
a8378ec
Compare
3 tasks
Owner
|
Incorporated into v0.7.1 (commit 96b4998) with one reconciliation: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker-compose.dev.ymlhardcoded most environment variables to fixed literal values (e.g.NODE_ENV=development,DATABASE_TYPE=sqlite,PUPPETEER_HEADLESS=true,WEBHOOK_TIMEOUT=10000, ...). There was no way to override them from the shell environment or an.envfile without editing the compose file.This converts the user-facing settings to the
${VAR:-default}pattern — same defaults as before, but now overridable — bringing the dev compose in line with the productiondocker-compose.yml.Made overridable (default unchanged)
NODE_ENV,DATABASE_TYPE,DATABASE_NAME,DATABASE_SYNCHRONIZE,ENGINE_TYPE,PUPPETEER_HEADLESS,PUPPETEER_ARGS,STORAGE_TYPE,WEBHOOK_TIMEOUT,WEBHOOK_MAX_RETRIES,QUEUE_ENABLED, plus the data-path settings documented in.env.example:SESSION_DATA_PATH,STORAGE_LOCAL_PATH. Also addedLOG_LEVEL=${LOG_LEVEL:-info}for parity with production.The data-path defaults stay under
/app/data(the./databind mount), so persistence is unchanged out of the box; override only if you mount that target elsewhere.Intentionally kept fixed
PORT,HOME,XDG_CONFIG_HOME,XDG_CACHE_HOME— container-internal values that must match the image/entrypoint. Production keeps these fixed for the same reason.Notes
WWEBJS_*were already parameterized; unchanged.docker compose -f docker-compose.dev.yml upbehavior is unchanged when no env is set.Test plan
docker compose -f docker-compose.dev.yml configparses successfullydocker compose -f docker-compose.dev.yml upwith no env uses the prior defaultsLOG_LEVEL=debug/PUPPETEER_HEADLESS=falsein.envoverrides the defaults