Skip to content

revert: serve lock RPC over goridge net/rpc, keep the new API - #91

Merged
rustatian merged 1 commit into
masterfrom
revert/connectrpc
Jul 15, 2026
Merged

revert: serve lock RPC over goridge net/rpc, keep the new API#91
rustatian merged 1 commit into
masterfrom
revert/connectrpc

Conversation

@rustatian

Copy link
Copy Markdown
Member

Part of the org-wide Connect-RPC revert: the RPC surface returns to net/rpc over the goridge codec while keeping the new api-go message set and method names. Connect handlers were converted in place, connect-only API tests removed, and api-go/goridge/rpc are pinned to the revert branches (pseudo-versions to be replaced by tags).

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Copilot AI review requested due to automatic review settings July 14, 2026 21:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the lock service RPC transport from Connect-RPC back to net/rpc over the goridge codec while keeping the newer api-go message set and method names, and adjusts tests/dependencies accordingly.

Changes:

  • Convert lock RPC handlers from Connect request/response types to net/rpc style (in, out) error.
  • Update test RPC client helper to use net/rpc + goridge codec; remove Connect-only API tests and config.
  • Pin api-go, goridge, and rpc dependencies to revert-branch pseudo-versions; remove Connect-related deps.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/rpc.go Switch test client helper from Connect to net/rpc + goridge codec.
tests/lock_api_test.go Remove Connect/HTTP/gRPC API surface tests tied to Connect handlers.
tests/go.mod Drop Connect/grpc deps; add goridge + pin pseudo-versions for revert branches.
tests/go.sum Remove Connect/grpc-related sums; add goridge + updated pseudo-version sums.
tests/configs/.rr-lock-api.yaml Remove config used by the deleted Connect API tests.
rpc.go Convert RPC methods from Connect handler signatures to net/rpc method signatures.
plugin.go Expose RPC service object instead of an HTTP handler for Connect.
go.mod Remove Connect requirement; pin api-go pseudo-version.
go.sum Remove Connect-related sums; add updated api-go pseudo-version sums.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/rpc.go
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.19048% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.53%. Comparing base (ce96fc3) to head (5f4fdca).

Files with missing lines Patch % Lines
rpc.go 75.00% 5 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   79.37%   80.53%   +1.16%     
==========================================
  Files           4        4              
  Lines         674      668       -6     
==========================================
+ Hits          535      538       +3     
+ Misses        119      111       -8     
+ Partials       20       19       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rustatian
rustatian merged commit b18af12 into master Jul 15, 2026
8 of 9 checks passed
@rustatian
rustatian deleted the revert/connectrpc branch July 15, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants