Skip to content

chore(tests): fix kv alloc underflow and PQ start-count flakiness #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rustatian merged 2 commits into from
Jul 16, 2026
Merged

chore(tests): fix kv alloc underflow and PQ start-count flakiness #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7718c3e
chore(tests): fix kv alloc underflow and PQ start-count flakiness
rustatian Jul 16, 2026
b3d3960
chore(tests): cover kv/v6 rpc spans, requeue logging; add missing cle…
rustatian Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion memorykv/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,10 @@ func (d *Driver) Delete(ctx context.Context, keys ...string) error {
return nil
}

func (d *Driver) Clear(_ context.Context) error {
func (d *Driver) Clear(ctx context.Context) error {
_, span := d.tracer.Tracer(tracerName).Start(ctx, "inmemory:clear")
defer span.End()

// stop all callbacks
close(*d.broadcastStopCh.Load())

Expand Down
6 changes: 4 additions & 2 deletions tests/jobs_memory_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,9 @@ func TestMemoryPQ(t *testing.T) {
assert.Equal(t, 2, oLogger.FilterMessageSnippet("pipeline was started").Len())
assert.Equal(t, 2, oLogger.FilterMessageSnippet("pipeline was stopped").Len())
assert.Equal(t, 200, oLogger.FilterMessageSnippet("job was pushed successfully").Len())
assert.Equal(t, 4, oLogger.FilterMessageSnippet("job processing was started").Len())
// the exact number of started jobs depends on how many nack/re-dispatch cycles
// fit into the pipeline-destroy window, which varies between machines
assert.GreaterOrEqual(t, oLogger.FilterMessageSnippet("job processing was started").Len(), 2)
}

func TestMemoryInitV27(t *testing.T) {
Expand Down Expand Up @@ -688,7 +690,7 @@ func TestMemoryJobsError(t *testing.T) {

assert.Equal(t, 1, oLogger.FilterMessageSnippet("job was pushed successfully").Len())
assert.Equal(t, 4, oLogger.FilterMessageSnippet("job processing was started").Len())
assert.Equal(t, 4, oLogger.FilterMessageSnippet("job was processed successfully").Len())
assert.Equal(t, 1, oLogger.FilterMessageSnippet("job was processed successfully").Len())
assert.Equal(t, 1, oLogger.FilterMessageSnippet("pipeline was paused").Len())
assert.Equal(t, 1, oLogger.FilterMessageSnippet("pipeline was resumed").Len())
assert.Equal(t, 1, oLogger.FilterMessageSnippet("pipeline was stopped").Len())
Expand Down
10 changes: 9 additions & 1 deletion tests/kv_memory_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ func TestSetManyMemory(t *testing.T) {
currAlloc := ms.Alloc
currNg := runtime.NumGoroutine()

if currAlloc-prevAlloc > 20_000_000 { // 20MB
if currAlloc > prevAlloc && currAlloc-prevAlloc > 20_000_000 { // 20MB
t.Log("Prev alloc", prevAlloc)
t.Log("Curr alloc", currAlloc)
t.Error("Memory leak detected")
Expand Down Expand Up @@ -536,12 +536,20 @@ func TestInMemoryKVTracer(t *testing.T) {
uniqueNames := slices.Sorted(maps.Keys(spanNames))

expected := []string{
"inmemory:clear",
"inmemory:delete",
"inmemory:has",
"inmemory:mexpire",
"inmemory:mget",
"inmemory:set",
"inmemory:ttl",
"kv:clear",
"kv:delete",
"kv:has",
"kv:mexpire",
"kv:mget",
"kv:set",
"kv:ttl",
}

assert.Equal(t, expected, uniqueNames)
Expand Down
Loading