Three review findings: a text token at 2.19:1, a check that saw half its ground, a dead rule - #52
Merged
Merged
Conversation
…eadable --c-weak text override
- design tokens v10 and deck transport v8 land on every page and both decks
- verify/check.mjs: readoutInvariant: true on both deck pages (mental-model, essential-complexity)
- remove `.never li b{color:var(--c-weak)}` from privacy/, principles/ and model/ — a text
use of a token the spec forbids for text, measuring 2.38:1 dark / 2.19:1 light and paler
than its own explanation text; `.card li b` already inherits --ink, the correct strength
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three findings from the whole-branch review of the theme work, now that it has merged. Takes
@robertblust/designv0.11.3.--c-weakwas carrying text at 2.19:1..never li b{color:var(--c-weak)}coloured the terms in the "Not used at all" card — Cookies, Analytics, Third-party requests. The intent was good, and the comment above it said so:--c-weakmeans "a candidate: considered, not accepted", which is exactly what that card lists.But it is a text use of a token the spec declares must never carry text, at 2.38:1 dark and 2.19:1 light. And
.card li i— the explanation beside each term — is--dimat ~5.6:1, so the term read paler than its own description and the hierarchy ran backwards.The rule is gone.
.card li balready inherits--ink, which is the right strength for a term, and the meaning an unreadable colour was trying to restate is already carried by the card's own heading. The comment stays, reworded to explain the card rather than a colour choice that no longer exists.It also appeared on more pages than the class does — on blust.ch,
model/andprinciples/carried the rule with no.neverelement at all. No text-bearing--c-weakremains anywhere in the family.readoutInvariantis switched on for the four decks. The deck's readout stays dark in both themes while the slab around it pales, and a test already enforced that nothing which flips is painted inside.lcd— but it scanned only the package's own block. A.lcdrule in a deck page's own CSS was invisible to it, and todesign:check, which compares bytes between markers only. The new check fetches the served page and scans all of it. Proven by injecting.lcd{color:var(--c-mid)}outside the fence and watching it fail.A dead rule and its token are gone —
.lcd .n.msgand--lcd-flag, the last survivors of the message pathdeck runtimev4 deleted.Every card re-rendered byte-identical; only the stamps moved.
🤖 Generated with Claude Code