Conversation
…alo-light Swaps crates/ (core/fixtures/halo/ui -> halo/halo-light) and the root Cargo.toml/Cargo.lock for the new dual-deck DJ app with lighting layer, while keeping shows/, docs, CI, and other project metadata from this repo.
The ported code wasn't formatted against this repo's rustfmt.toml (group_imports/imports_granularity=Module). No behavioral change.
crates/halo/Cargo.toml depends on ../../../timestretch-rs as a path dependency (it's published to crates.io at 0.8.0 but halo's code already uses PreAnalysisArtifact::resample_to, added after that release — so a registry dependency isn't viable yet). CI's checkout only had this repo, so the path resolved to a nonexistent directory and every job failed at the formatting-check step before it could build anything. Check out robmorgan/timestretch-rs (public) one level above this checkout so the same relative path that works locally also resolves in CI.
actions/checkout@v6 refuses `path: ../timestretch-rs` directly ("Repository
path ... is not under ..."). Check out into an in-workspace subdirectory
instead and mv it up a level in a plain shell step.
… libs winit refuses to build at all on Linux without at least one windowing backend feature enabled. crates/halo disables eframe's default features and only opted into accesskit/default_fonts/persistence/wgpu, dropping the x11/wayland features that normally come along with eframe's defaults. Add them back, and install the dev packages winit/smithay-client-toolkit need to link against on the CI runner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/(core/fixtures/halo/ui) with the new dual-deck DJ app +halo-lightlighting layer fromrobmorgan/halo(the sibling working repo), along with the matching rootCargo.toml/Cargo.lock..claude/(project skills, e.g. thescreenshotskill) andROADMAP.mdfrom the source repo — additive, no conflicts.shows/,_docs/,docs/, root markdown (README.md,CLAUDE.md,CONTRIBUTING.md,TODO.md,LICENSE.md), CI (.github/),.gitignore,rustfmt.toml,.vscode/,config.json/config.template.json,start.sh/start-capture.sh,exp/.rustfmt.toml(nightly-only import grouping) — no behavior change.Test plan
cargo build --workspace— clean (only 2 pre-existing dead-code warnings from the source repo)cargo test --workspace— 93/93 passingcargo +nightly fmt --all -- --check— cleaneframe'swgpubackend (previously this repo's UI used theglowbackend) — watch the Linux job and add apt packages if it fails to link