Skip to content

Support optimal confidence from model-eval#2242

Draft
leeclemnet wants to merge 34 commits intomainfrom
feat/model-eval-recommended-defaults
Draft

Support optimal confidence from model-eval#2242
leeclemnet wants to merge 34 commits intomainfrom
feat/model-eval-recommended-defaults

Conversation

@leeclemnet
Copy link
Copy Markdown
Contributor

@leeclemnet leeclemnet commented Apr 17, 2026

What does this PR do?

Redo of #2206, which was reverted by #2241.

Includes fixes for bugs found after merging #2206 to main.

Type of Change

  • New feature (non-breaking change that adds functionality)

Testing

  • I have tested this change locally
  • I have added/updated tests for this change

Test details:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in hard-to-understand areas
  • My changes generate no new warnings or errors
  • I have updated the documentation accordingly (if applicable)

Additional Context

@leeclemnet leeclemnet changed the title Feat/model eval recommended defaults Support optimal confidence from model-eval Apr 17, 2026
leeclemnet added 29 commits April 17, 2026 17:07
@leeclemnet
squash commit
d3c5344
@leeclemnet
Show confidence hint 0.4 to match default
216b373
@leeclemnet
dev dockerfiles overlay inference_models source build
b67759d
@leeclemnet
confidence filter debug logging
2a39f9e
@leeclemnet
confidence filter lazy imports not needed
a6d348f
@leeclemnet
drop unneeded comment
85af4a1
@leeclemnet
kwargs.get(recommended_parameters) -> Optional[RecommendedParameters]…
27133cb 
…=None
@leeclemnet
per-model default confidence, move to post_processing, inline per-ima…
c669544 
…ge refinement into existing loops
@leeclemnet
concrete class post_process confidence optional default None
fdc88e0
@leeclemnet
cleanup
0319e63
@leeclemnet
simplify ConfidenceFilter and avoid double filtering
6090871
@leeclemnet
fix OOB bugs in yolov5/7 and rfdetr
655fd9b
@leeclemnet
confidencefilter readability
b30215b
@leeclemnet
undo no-op diffs
f289b53
@leeclemnet
revert workflow UI change for now
8564ea6
@leeclemnet
deeplapv3plus: drop double construction of SemanticSegmentationResult
2f0b722
@leeclemnet
Explicit 'best', 'default' or float confidence - easy opt-out
7435547
@leeclemnet
legacy inference ignore string valued confidence
e72bb14
@leeclemnet
move Confidence to entities, validation throws ModelInputError, hint …
27ca8ff 
…confidence Tensor contents
@leeclemnet
use pydantic native ge/le validation instead of annotated_types
9abf606
@leeclemnet
keep 0.5 request default, default to 'default' in SDK instead of 'best'
4b818da
@leeclemnet
scalar threshold fast path
5f8a36c
@leeclemnet
fix yolov10
576ff5b
@leeclemnet
update inference_sdk
cb5351b
@leeclemnet
drop pydantic validation on confidence
8f5a853
@leeclemnet
bump version to 0.25.0, update changelog, revert Dockerfile and CI ch…
396952d 
…ange
@leeclemnet
bump inference-models requirements to 0.25.0
0e87734
@leeclemnet
fix roboflow-instant-hf scalar confidence path
87b17c1
@leeclemnet
bump inference-models version 0.25.1
0174623
@leeclemnet leeclemnet force-pushed the feat/model-eval-recommended-defaults branch 2 times, most recently from b34d0b2 to e6ee003 Compare April 17, 2026 20:11
@leeclemnet leeclemnet force-pushed the feat/model-eval-recommended-defaults branch from e6ee003 to 08fd135 Compare April 17, 2026 20:56
@leeclemnet leeclemnet marked this pull request as ready for review April 17, 2026 21:17
@leeclemnet leeclemnet force-pushed the feat/model-eval-recommended-defaults branch from d7263ee to dea272e Compare April 17, 2026 22:34
@leeclemnet leeclemnet marked this pull request as draft April 17, 2026 22:35
@leeclemnet leeclemnet force-pushed the feat/model-eval-recommended-defaults branch 3 times, most recently from aa778ae to 3916ba4 Compare April 17, 2026 23:28
@leeclemnet leeclemnet force-pushed the feat/model-eval-recommended-defaults branch from 3916ba4 to 9ecf1b3 Compare April 17, 2026 23:40
@leeclemnet leeclemnet force-pushed the feat/model-eval-recommended-defaults branch from bed5679 to c15bf41 Compare April 18, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PawelPeczek-Roboflow PawelPeczek-Roboflow Awaiting requested review from PawelPeczek-Roboflow PawelPeczek-Roboflow is a code owner

@grzegorz-roboflow grzegorz-roboflow Awaiting requested review from grzegorz-roboflow grzegorz-roboflow is a code owner

@hansent hansent Awaiting requested review from hansent hansent is a code owner

@yeldarby yeldarby Awaiting requested review from yeldarby yeldarby is a code owner

@probicheaux probicheaux Awaiting requested review from probicheaux probicheaux is a code owner

@dkosowski87 dkosowski87 Awaiting requested review from dkosowski87 dkosowski87 is a code owner

@rafel-roboflow rafel-roboflow Awaiting requested review from rafel-roboflow rafel-roboflow is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@leeclemnet