Skip to content

Fix flaky unit test#2628

Open
PawelPeczek-Roboflow wants to merge 2 commits into
mainfrom
fix/flakyness-in-unit-test
Open

Fix flaky unit test#2628
PawelPeczek-Roboflow wants to merge 2 commits into
mainfrom
fix/flakyness-in-unit-test

Conversation

@PawelPeczek-Roboflow

@PawelPeczek-Roboflow PawelPeczek-Roboflow commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixing flakyness in unit test

we monkeypatch url_input.socket.getaddrinfo with fake value but it happens we have other calls (probably from threded activity of inference) intercepted there - changed the way of mocking

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

Testing

  • ci
  • I have tested this change locally
  • I have added/updated tests for this change

Test details:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in hard-to-understand areas
  • My changes generate no new warnings or errors
  • I have updated the documentation accordingly (if applicable)

Additional Context

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

👋 Thanks for the pull request! Here is how automated Claude review works here, so you spend credits (and reviewer time) wisely.

🚧 Right now this is a draft, so automated Claude review is paused — nothing is being spent yet. Mark it Ready for review to trigger it.

Warning

💸 The Claude reviewer bills in credits, not vibes

Automated review spins up a real agent that reads real code and spends real credits on every pass. It is glad to help — but it is not a rubber duck, a linter you poke in a loop, or a substitute for reading the contributing guide. Treat it like an expensive senior reviewer whose time you booked, and show up prepared.

Draft when unsure, Ready when you mean it:

  • 🌱 Not sure the PR is in good shape yet? Keep it (or set it back) as a draft — drafts pause review, so you can push and iterate without burning credits on a moving target.
  • 💪 Feel strong about the contents? Mark it Ready for review and the reviewer will take a look.

However you get there, arrive prepared:

  • 🧱 Bring a SOLID, thorough PR. Point your local agent at our skills/ to tune it to our guidelines first — or, if you are one of those fabled carbon-based contributors, read them yourself. A half-baked diff costs exactly the same to review as a finished one.
  • Resolve every comment before you re-request review. Re-requesting with threads still open means paying twice for the same conversation.
  • 🔁 Do not use CI review as an inner loop for a local agent. The reviewer is not a step-by-step debugger — do the unfolding locally and arrive with the answer, not the search.
  • 🙋 If something looks off, ask a human. One question to a maintainer is cheaper and faster than three rounds of agent re-review chasing a misread.

Reviews are not free. A draft costs nothing to review; a Ready PR is a promise that it is worth reviewing.

  • Prefer to skip automated review entirely? Add the skip-claude-review label.

Comment thread tests/inference/unit_tests/core/utils/test_image_utils.py Fixed
@PawelPeczek-Roboflow PawelPeczek-Roboflow added the skip-claude-review Opt this PR out of automated Claude review label Jul 8, 2026
@PawelPeczek-Roboflow PawelPeczek-Roboflow marked this pull request as ready for review July 8, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-claude-review Opt this PR out of automated Claude review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants