Update review skills and changelogs to use unreleased section#2672
Conversation
|
👋 Thanks for the pull request! Here is how automated Claude review works here, so you spend credits (and reviewer time) wisely. 🚦 This PR is marked Ready for review, so automated Claude review will run — and every pass spends real credits. Warning 💸 The Claude reviewer bills in credits, not vibesAutomated review spins up a real agent that reads real code and spends real credits on every pass. It is glad to help — but it is not a rubber duck, a linter you poke in a loop, or a substitute for reading the contributing guide. Treat it like an expensive senior reviewer whose time you booked, and show up prepared. Draft when unsure, Ready when you mean it:
However you get there, arrive prepared:
Reviews are not free. A draft costs nothing to review; a Ready PR is a promise that it is worth reviewing.
|
|
🤖 Claude review started at commit New commits are not auto-reviewed. Add the |
| - **Tests** — unit test always; integration test for new or output-changing blocks (#2362, #718). | ||
| - **`__init__.py`** — in every new/nested block package (#2351, #830). | ||
| - **EE version + changelog** — ONLY when the block forces an EE behavior change: bump `EXECUTION_ENGINE_V1_VERSION` (`execution_engine/v1/core.py`) + entry in `docs/workflows/execution_engine_changelog.md` (#2527). | ||
| - **EE changelog** — ONLY when the block forces an EE behavior change: add an entry under `## Unreleased` in `docs/workflows/execution_engine_changelog.md`; maintainers bump `EXECUTION_ENGINE_V1_VERSION` at release time. |
There was a problem hiding this comment.
Medium — incomplete migration leaves contradictory version-bump guidance in this same skill.
This PR updated this "Required companions" bullet to the Unreleased model (contributor adds a ## Unreleased entry; maintainers bump EXECUTION_ENGINE_V1_VERSION at release time). But two other lines in this same file were left on the old policy and now directly contradict it:
- Line 24 (
7. **FLAG — EE compatibility**): "If the PR bumpsEXECUTION_ENGINE_V1_VERSION, require a changelog entry + version-assert test updates …" — still tells the reviewer to require contributor version-assert test updates. - Line 49 (Standards,
**EE compatibility**): "Only bump it (+ changelog + version-assert tests) when the block forces an EE behavior change (Revert "Add tracklet recognition workflow blocks" #2527 …)" — still instructs the contributor to bump the EE version and update version-assert tests.
Both conflict with the new line 62 here and with the sibling review-workflows-execution-engine skill (updated in this PR to "Never demand an EXECUTION_ENGINE_V1_VERSION … bump from a contributor" and "Version-assertion tests change only in the maintainer release PR") and review-topic-backward-compat-and-versioning §3. A reviewer loading review-workflows-blocks on a block PR that forces an EE change would get conflicting guidance and could still demand a contributor version bump — exactly what this PR aims to eliminate.
Please update lines 24 and 49 to the Unreleased model (contributor adds the ## Unreleased entry; maintainers bump the EE version + version-assert tests at release).
Review summaryThis PR migrates the review skills, the cursor rule, the review prompt, and the two changelog docs from a contributor-owned version bump model to an Unreleased-section model (contributors record changes under One blocking-quality finding (Medium):
No other blocking findings. No IMPORTANT clarification questions are open. Commands used: Re-review is not automatic — after pushing the fix, remove and re-add the Reviewed at HEAD: 36068a4 |
What does this PR do?
Unreleasedsection inCHANGELOGs for contributors to fillType of Change
Checklist