License missing: add galaxea robot #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephane-caron
requested changes
Oct 14, 2025
Member
stephane-caron
left a comment
stephane-caron
left a comment
There was a problem hiding this comment.
Thank you for starting this PR 👍 Currently the tests won't pass because of the url issue (see suggestion comment).
Co-authored-by: Stéphane Caron <1189580+stephane-caron@users.noreply.github.com>
Member
|
Thank you for following up 👍 The failing CI is caused by another issue unrelated to this PR. I will go ahead and merge this, then fix continuous integration in #187. |
stephane-caron
merged commit 2eec699
into
robot-descriptions:main
7 of 15 checks passed
stephane-caron
added a commit
that referenced
this pull request
Nov 17, 2025
stephane-caron
added a commit
that referenced
this pull request
Nov 17, 2025
Member
|
My apologies for not checking carefully: actually we can't add this description yet because it is not covered by an open-source license; see Adding a new robot description in the contribution guidelines. I am temporarily reverting the addition in ec3804c until we verify all checks. Can an open-source license be added upstream? Or is there an alternative repository for this robot description with an open-source license? |
stephane-caron
added a commit
that referenced
this pull request
Nov 17, 2025
stephane-caron
added a commit
that referenced
this pull request
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.