-
Notifications
You must be signed in to change notification settings - Fork 781
Closed
Labels
priority: criticaltaskGeneric task not listed in release notesGeneric task not listed in release notes
Milestone
Description
ApprovalTests is an interesting concept, which would help writing unit tests. Unfortunately, adding ApprovalTests as a dev dependency does not work out of the box or like #1147 . This is because ApprovalTests does not work with Jython and there is bug with pypy compatibility. But the issue with pypy should be resolved if my PR is approved.
To take approval test in use.
- Update unit test documentation
- Solve the problem with Jython
- Wait for pypy support release
- Write some example tests.
The Jython problem is difficult to solve, because there is import error during the installation: ImportError: cannot import name c_wchar_p. But it could be solved in following way
- Tune Jython installation in Travis not to install ApprovalTests
- In unit test, make
try/exceptin import of ApprovalTests - Create skip for unit test if running with Jython and use it when running test with ApprovalTests.
Metadata
Metadata
Assignees
Labels
priority: criticaltaskGeneric task not listed in release notesGeneric task not listed in release notes