Skip to content

Conversation

S-Dafarra
Copy link
Contributor

No description provided.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @S-Dafarra

There are a bunch of conflicts.
Could you please have a look at them?

@S-Dafarra
Copy link
Contributor Author

Hi @pattacini, yes I noticed. I thought of opening this PR to tackle these conflicts in view of #307. Actually, I would need the @ale-git help on this. The version of this branch is the one used currently on the robot.

I know we edited the calibrationDelta, but all the other conflicts are a bit obscure to me. If you could provide some insights that would be great

@ale-git
Copy link
Contributor

ale-git commented Nov 12, 2021

Maybe I can compile a little "how-to" change the calibration mode from absolute (type 12) to hard-stop (type 10), so that people can understand what's going on?

@pattacini
Copy link
Member

Maybe I can compile a little "how-to" change the calibration mode from absolute (type 12) to hard-stop (type 10), so that people can understand what's going on?

That would be fantastic indeed 👍🏻

@pattacini
Copy link
Member

pattacini commented Nov 12, 2021

Hi @S-Dafarra

I know we edited the calibrationDelta, but all the other conflicts are a bit obscure to me. If you could provide some insights that would be great

Most likely, the conflicts are generated by #307 that has been merged.

My proposal is:

@S-Dafarra
Copy link
Contributor Author

Maybe I can compile a little "how-to" change the calibration mode from absolute (type 12) to hard-stop (type 10), so that people can understand what's going on?

That would help, but I also see some unexpected changes, like:

  • the hip roll lower limit changed from -15 to -5 (quite critical for the walking)
  • the hip pitch upper limit changed from 110 to 90
  • the Gearbox_E2J changed from 1 to 64 (does this affect the computation of the joint velocity?)
  • the resolution and the tolerance of the encoders changed

@ale-git
Copy link
Contributor

ale-git commented Nov 12, 2021

Hi @S-Dafarra:

  • the -5 deg hip roll limit is the value in robotology, feel free to change it (the physical limit is about -20 deg)
  • the +90 deg hip pitch is the physical limit, there is no way you can go higher :)
  • the Gearbox_E2J is correct, it means that the 14 bit resolution of the AMO is repeated 64 or 32 times per physical revolution. The velocity isn't affected since this information is used at lower level to compute a 16 bit absolute angle measure.
  • the resolution (16384) reflects the 14 bit per sector of the AMO, that multiplied by 64 sectors gives the same 2^20 former resolution.

@S-Dafarra
Copy link
Contributor Author

Ok, great, thanks @ale-git. Then I think I can resolve the conflicts myself!

@S-Dafarra
Copy link
Contributor Author

I fixed the conflicts in a new branch. Closing this in favor of #309

@S-Dafarra S-Dafarra closed this Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants