Skip to content

Self host cli and docs - #555

Merged
RoiGlinik merged 22 commits into
masterfrom
self-host-cli-and-docs
Nov 13, 2022
Merged

Self host cli and docs#555
RoiGlinik merged 22 commits into
masterfrom
self-host-cli-and-docs

Conversation

@RoiGlinik

Copy link
Copy Markdown
Contributor

This is adds the new CLI command to generate the self host values + backend config.
Also migrated the guides to the docs.

@arikalon1 arikalon1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Left some minor comments.
Feel free to fix and merge

Comment thread docs/self-host/google-sso.rst Outdated
Comment thread docs/self-host/slack.rst
Comment thread docs/self-host/bare.rst Outdated
Comment thread docs/self-host/gke.rst Outdated
Comment thread docs/self-host/google-sso.rst Outdated
Comment thread src/robusta/cli/self_host.py
Comment thread src/robusta/cli/self_host.py Outdated
JWT_SECRET: str = gen_secret(32)
JWT_EXPIRY: int = 3600
ANON_KEY: str = JWT.encode(
{"role": "anon", "iss": "supabase", "iat": 1661029200, "exp": 1818795600},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would comment what iss/iat/exp means
And I would put the values in constants with meaningful names.
For example: 1_DAY_EXPIRATION = 1818795600

Comment thread src/robusta/cli/self_host.py Outdated
Comment thread src/robusta/cli/self_host.py Outdated
Comment thread src/robusta/cli/self_host.py Outdated
@RoiGlinik
RoiGlinik merged commit 28dbc05 into master Nov 13, 2022
@RoiGlinik
RoiGlinik deleted the self-host-cli-and-docs branch November 13, 2022 09:08
pavangudiwada pushed a commit to pavangudiwada/robusta that referenced this pull request Nov 6, 2023
* new self-host command menu. base gen-config command
* add docs for gke, on prem and slack app
* adding code blocks the option to add prompt lines that will only be copied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants