Skip to content

Simplified Dockerfile with a little reduced size - #559

Merged
RoiGlinik merged 2 commits into
robusta-dev:masterfrom
pavangudiwada:dockerfilechange
Oct 11, 2022
Merged

Simplified Dockerfile with a little reduced size#559
RoiGlinik merged 2 commits into
robusta-dev:masterfrom
pavangudiwada:dockerfilechange

Conversation

@pavangudiwada

Copy link
Copy Markdown
Contributor
  • Added --no-dev for all poetry install commands, helps save space and time by not installing Dev dependencies (sphinx)
  • Moved some commands around, this doesn't have an impact on the size of the image but saves time spent on updating the Repositories multiple times.

@pavangudiwada
pavangudiwada requested a review from aantn October 2, 2022 10:34
@aantn
aantn requested review from RoiGlinik and removed request for aantn October 2, 2022 14:27
@aantn

aantn commented Oct 2, 2022

Copy link
Copy Markdown
Collaborator

@RoiGlinik re-assigning to you

Comment thread Dockerfile Outdated

@RoiGlinik RoiGlinik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to delete some extra old package and its good

@RoiGlinik

Copy link
Copy Markdown
Contributor

ruamel.yaml.clib lib released a wheel a few weeks ago so there is no need for gcc and the rumal.aml.lib line can be deleted

@RoiGlinik
RoiGlinik merged commit 4b56be2 into robusta-dev:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants