Re-pin release-package actions to the follow-up PR lookup fix - #469
Merged
Conversation
`create-followup-pr` is called twice per release, so the second call must update the PR opened by the first. Upstream's lookup passed `owner:branch` to `gh pr list --head`, which matches headRefName literally and so never matched; the update fell through to `gh pr create` and failed with "A pull request already exists". On 0.21.0 that failure sat ahead of the Pages steps in publish-docs, so Create Pages tree, Upload Pages artifact and Deploy Pages were all skipped and the docs site kept redirecting to 0.20.0. Pins every action to af2f0cd (roc-lang/release-package#4). This also moves publish-release forward from 48ccc90, which is an ancestor of af2f0cd and still exposes the additional_assets input this workflow relies on. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The follow-up PR step only opens a PR for humans to merge later; nothing in publish-docs consumes its outputs. Running it ahead of the Pages steps meant any failure there took the docs deployment down with it, which is exactly how 0.21.0 shipped without docs. Moving it after Deploy Pages makes the deployment structurally independent of it, so a token problem or a branch-protection change can no longer leave the site stale. The step sees the same working tree in either position: examples are rewritten near the top of the job, and `git checkout -B` only moves a branch pointer at HEAD. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
CI needs roc-lang/roc#10685 to pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create-followup-pris called twice per release, so the second call must update the PR opened by the first. Upstream's lookup passedowner:branchtogh pr list --head, which matches headRefName literally and so never matched; the update fell through togh pr createand failed with "A pull request already exists".On 0.21.0 that failure sat ahead of the Pages steps in publish-docs, so Create Pages tree, Upload Pages artifact and Deploy Pages were all skipped and the docs site kept redirecting to 0.20.0.
Pins every action to af2f0cd (roc-lang/release-package#4). This also moves publish-release forward from 48ccc90, which is an ancestor of af2f0cd and still exposes the additional_assets input this workflow relies on.