Migrate examples to the new compiler - #258
Merged
Merged
Conversation
…ommandLineArgs, CustomInspect, ErrorHandlingBasic, FizzBuzz, GraphTraversal, HelloWorld, ImportFromDirectory, ImportFromDirectory, IngestFiles, Json, LeastSquares, MultiLineComments, MultipleRocFiles, MultipleRocFiles, PatternMatching, SafeMath, TowersOfHanoi, TryOperatorDesugaring, Tuples
…lmFrontendRocBackend.exp to ElmWebApp.exp
Anton-4
requested changes
Aug 5, 2026
Anton-4
left a comment
Anton-4
left a comment
Collaborator
There was a problem hiding this comment.
Thanks a lot @ageron!
I just fixed some minor issues and I have some (minor) rabbit holes saved in a txt file on my desktop. I can continue my review on Friday.
If there is desire to push this through quicker I think only the nix files need to be torn out and CI should only run using a Roc release build and no debug build because it hits a stack overflow.
Collaborator
I am not going to make it, lots of tangents today. Hopefully better tomorrow. |
ageron
marked this pull request as ready for review
August 7, 2026 21:57
Anton-4
approved these changes
Aug 8, 2026
Contributor
Author
|
Thanks for reviewing, @Anton-4. Note that I can't merge the PR (the message says "New changes require approval from someone other than Anton-4 because they were the last pusher.") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to migrate all examples to the new compiler, starting with the examples that can run on the echo platform, without any library dependency:
Edit: also migrated the following examples which depend on the
basic-cliplatform and a few libraries:unicodelibrary)parserlibrary)randlibrary)The following examples were dropped (possibly temporarily):