Make DebugAllocator stack traces opt-in via -Ddebug-gpa-traces#10136
Merged
Conversation
Capturing a 6-frame stack trace on every allocation dominated Debug-build runtime (~80% of `roc test` wall time on macOS arm64) and was timing out the JSON CLI tests. Leaks are still detected without traces; traceless leak reports now print a hint to rebuild with -Ddebug-gpa-traces. JsonStringEscapes 57s -> 3.6s, JsonEncodeRoundTrip 89s -> 11s, run-check-snapshots 70s -> 16s. CI re-runs a failed step with -Ddebug-gpa-traces (via the new debug-gpa-retrace action) when its output contains leak reports, so the log gains allocation-site traces; the job still fails with the original exit code. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capturing a 6-frame stack trace on every allocation dominated Debug-build runtime (~80% of
roc testwall time on macOS arm64) and was timing out the JSON CLI tests. Leaks are still detected without traces; traceless leak reports now print a hint to rebuild with -Ddebug-gpa-traces.JsonStringEscapes 57s -> 3.6s, JsonEncodeRoundTrip 89s -> 11s, run-check-snapshots 70s -> 16s.
CI re-runs a failed step with -Ddebug-gpa-traces (via the new debug-gpa-retrace action) when its output contains leak reports, so the log gains allocation-site traces; the job still fails with the original exit code.