Warn on unconditional conditions#9816
Merged
Merged
Conversation
rtfeldman
force-pushed
the
warn-unconditional-condition
branch
from
June 25, 2026 22:27
ff9d685 to
ddb2f0a
Compare
rtfeldman
marked this pull request as ready for review
June 26, 2026 12:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a warning when an if condition, match scrutinee, or match guard is known at compile time, making the conditional choose deterministically. The check is emitted during type checking from the existing hoistability information, so it stays tied to the condition expression itself and does not change compile-time branch coverage reporting.