fix(deps): fail fast on stale runtime dependencies - #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The missing
workflowChildrenmetadata came from a run that started before Home Manager activated Patchmill 0.20.0. That running Pi process had already loaded an older Patchmill build withpi-subagents0.55.0. Home Manager activation changes what new processes load; it does not replace modules in an existing process.This change hardens source execution against a separate drift case:
package.jsoncan advance while the untrackednode_modulestree still reflects an earlier install.npm ls --depth=0beforenpm testpi-subagentsmatches Patchmill's exact pin before source CLI dispatchnpm installor packaged-install messageNo
npm installban is introduced.Tests
npm test— 1414/1414 passednix build path:.#patchmill --no-link --print-build-logs— passeddist/bin/patchmill.js version— passednpm lsboth fail before CLI dispatchKnown baseline failures
npm run check:typeshas unrelated existing failures; none reference changed filesnpm run check:architecturehas an existingextensions/todos.ts → typeboxviolation