fix: improve type checking for OptionalLoggerImpl#44
Merged
Conversation
Use the `this` type and not the interface because the implementation has private fields.
There was a problem hiding this comment.
Pull request overview
This PR refines the OptionalLogger API surface so the this context for its callable properties is typed as the concrete receiver type (polymorphic this) rather than the OptionalLogger interface type, which improves type-checking for implementations that use private fields (e.g., OptionalLoggerImpl with #logSink / #context).
Changes:
- Updated
OptionalLoggercallable property types (error/info/warn/debug/flush) to usethis: this. - Updated
OptionalLoggerImplcallable property types to usethis: this, aligning implementation typing with private-field usage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
thistype and not the interface because the implementation has private fields.