Skip to content

test: add at_least_until to have_no_new_sample #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
g-arjones wants to merge 1 commit into from
Closed

test: add at_least_until to have_no_new_sample #250

g-arjones wants to merge 1 commit into from

Conversation

@g-arjones
Copy link
Contributor

@g-arjones g-arjones commented May 25, 2020

@g-arjones g-arjones requested a review from doudou May 25, 2020 17:56
@g-arjones
Copy link
Contributor Author

g-arjones commented Jun 1, 2020

@doudou Did you miss this one?

doudou
doudou reviewed Jun 4, 2020
View reviewed changes
lib/syskit/test/execution_expectations.rb
# Implementation of the {#have_no_new_sample} predicate
class HaveNoNewSample < Roby::Test::ExecutionExpectations::Maintain
def initialize(reader, at_least_during, description, backtrace)
def initialize(reader, at_least, description, backtrace)
Copy link
Member

@doudou doudou May 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark about splitting at_least_during / at_least_until in the constructor.

@doudou
Copy link
Member

doudou commented Jun 4, 2020

Forgot to click on "submit review" :(

@doudou
Copy link
Member

doudou commented Jul 2, 2020

Hi @g-arjones, do you plan to continue working on this PR ?

@g-arjones
Copy link
Contributor Author

g-arjones commented Jul 2, 2020

Hey.. I do, yes (unless you want to takeover and finish it). It is on the bottom of my TODO list though

@doudou
Copy link
Member

doudou commented Jul 2, 2020

OK. Just to know.

@doudou doudou closed this May 13, 2025
@doudou doudou deleted the add_at_least_during_to_have_no_new_sample branch May 13, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doudou doudou doudou left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@g-arjones @doudou