Skip to content

smartnode should clean up keys from failed deposits #379

Description

@jshufro

image

basically, this is a land mine, and while it isn't smartnode's fault, if rocketpool node deposit exits with an error smartnode should delete the derived keys (but not decrement next_account).

This can be easily done with a defer that checks a bool that is only set on success, and if that bool is false, the keys are deleted

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions