fix: report missing repository preview credentials as a bad request - #5
Open
rodboev wants to merge 1 commit into
Open
fix: report missing repository preview credentials as a bad request#5rodboev wants to merge 1 commit into
rodboev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repository previews now return a 400 bad request when GitHub credentials are not configured, matching the existing runtime-token and registry-backed provider behavior. The legacy GitHub client adapter preserves the typed
provider_not_configurederror so the shared HTTP problem mapper applies that classification, while configured-client failures without a local configuration classification remain 502.This change covers the preview handler, provider registry, GitHub adapter, and HTTP problem mapper path described in @Technophobe01's report at kenn-io#675. The status contract follows the runtime-token handling introduced by @cpcloud in kenn-io#450.
Closes kenn-io#675