$maxgte emits a function that does not exist#69
Merged
Conversation
$maxgte emitted array_max(col) >= %s. That function is a custom definition on the LMFDB's own servers — where it is defined as exactly SELECT max(x) FROM unnest($1), IMMUTABLE, with zero functional indexes on it (checked on the production mirror) — and does not exist on a stock PostgreSQL, so the documented operator failed with UndefinedFunction everywhere else. The subquery is now emitted inline, which the planner treats identically on LMFDB and works on every database with no DDL. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$maxgteemittedarray_max(col) >= %s. That function is a custom definition on the LMFDB's own servers — where it is defined as exactlySELECT max(x) FROM unnest($1), IMMUTABLE, with zero functional indexes on it (checked on the production mirror) — and does not exist on a stock PostgreSQL, so the documented operator failed withUndefinedFunctioneverywhere else. The subquery is now emitted inline, which the planner treats identically on LMFDB and works on every database with no DDL.Split out of #60 (one PR per issue). This branch carries only this issue's fix and its tests; the rest of the known-bug inventory stays
xfailed, so the full suite is green here and the strict markers guarantee no cross-issue leakage.