Make sync previews and repository configuration auditable - #94
Merged
Conversation
Exercise config output, validation, idempotency, and non-mutation contracts alongside sync dry-run previews for fork and native-stack workflows plus clean autostash behavior, all through real temporary repositories and a strict no-network GitHub shim. Constraint: Dry-run tests must prove that neither GitHub nor stack state is mutated. Confidence: high Scope-risk: narrow Reversibility: clean Tested: cargo test --test sync_config_cli --all-features; cargo test --workspace --all-targets; cargo llvm-cov --workspace --all-targets; cargo clippy --all-targets --all-features -- -D warnings; cargo fmt --check Not-tested: Live GitHub sync mutation paths are covered in the native-stack and production canary suites.
Advance the bare remote without updating local tracking refs, then assert sync dry-run leaves origin/main unchanged for both fork and native-stack previews. Initialize the bare repository directly in its owned temp directory so cleanup removes the complete fixture. Constraint: A preview must not fetch, mutate stack state, or call GitHub. Confidence: high Scope-risk: narrow Reversibility: clean Tested: cargo test --test sync_config_cli --all-features; focused sync_dry_run tests; cargo clippy --test sync_config_cli --all-features -- -D warnings; cargo fmt --check Related: Independent review findings on PR #94.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a stack managed by
ez.