Ensure every plugin event has before/action/after variants - #1711
Merged
Conversation
Adds the missing middle event for addFile, removeFile, buildProgram, and writeProgram, and renames onGetSourceFixAllCodeActions to provideSourceFixAllCodeActions (with the matching before/after variants). The old name is kept as a deprecated type alias and forward-converted by the PluginInterface sanitizer so existing plugins continue to work. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
# Conflicts: # src/Program.ts # src/bscPlugin/BscPlugin.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1552. Every plugin event now exposes the full
beforeAction/action/afterActiontriplet.addFile,removeFile,buildProgram,writeProgram.onGetSourceFixAllCodeActions→provideSourceFixAllCodeActions(matches the earlieronGetCodeActions/onGetSemanticTokensrenames) and addedbeforeProvideSourceFixAllCodeActions/afterProvideSourceFixAllCodeActions.OnGetSourceFixAllCodeActionsEventtype is kept as a deprecated alias, andonGetSourceFixAllCodeActionsis forward-converted by thePluginInterfacesanitizer (with a warning) the same way other renamed hooks are.Test plan
npm run build— succeedsnpm run test:nocover— 4292 passing, 9 pending (no regressions)onGetSourceFixAllCodeActionshook still fires (with a deprecation warning) on a downstream consumerMerged latest
v1. The only conflicts were import lines colliding with v1's new inlay-hints event; v1 already emits the full inlay-hints triplet, so nothing here needed reworking.🤖 Generated with Claude Code