Skip to content

Fix compile break against roku-deploy 3.18#1752

Merged
chrisdp merged 2 commits into
masterfrom
fix/roku-deploy-loglevel-import
Jul 20, 2026
Merged

Fix compile break against roku-deploy 3.18#1752
chrisdp merged 2 commits into
masterfrom
fix/roku-deploy-loglevel-import

Conversation

@chrisdp

@chrisdp chrisdp commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Problem

roku-deploy 3.18.1 migrated to @rokucommunity/logger (rokucommunity/roku-deploy#318) and deleted its internal Logger module. ProgramBuilder.ts deep-imports that module:

import type { LogLevel as RokuDeployLogLevel } from 'roku-deploy/dist/Logger';

so brighterscript no longer compiles against roku-deploy >= 3.18. This currently breaks every create-vsix build in the org, since that pipeline compiles brighterscript master against roku-deploy master (first seen on rokucommunity/roku-debug#323).

Fix

  • Cast the three logLevel call sites to RokuDeployOptions['logLevel'] instead. The indexed type tracks whatever roku-deploy's options actually declare, so it compiles against both roku-deploy 3.17.x (LogLevel from the old internal Logger) and 3.18.x (LogLevel | LogLevelNumeric from @rokucommunity/logger). Verified tsc is clean against both versions.
  • Bump roku-deploy to ^3.18.1 so brighterscript CI compiles and tests against the same roku-deploy generation the create-vsix pipeline uses, and so brighterscript deploys pick up the large-upload EPIPE fix (Fix write EPIPE when uploading large zips through digest auth roku-deploy#324). @rokucommunity/logger dedupes to a single 0.4.1 copy. Full test suite passes (2979 tests).

chrisdp added 2 commits July 20, 2026 14:47
…gLevel'] instead of the deleted dist/Logger import

roku-deploy 3.18.1 migrated to @rokucommunity/logger and deleted its
internal Logger module, so the deep import of
'roku-deploy/dist/Logger' no longer resolves and every create-vsix
build (which compiles brighterscript master against roku-deploy
master) fails. Casting to RokuDeployOptions['logLevel'] tracks
whatever type roku-deploy's options actually use, so this compiles
against both roku-deploy 3.17.x and 3.18.x.
Delivers the large-upload EPIPE fix (rokucommunity/roku-deploy#324) and
makes brighterscript's own CI compile and test against the same
roku-deploy generation the create-vsix pipeline uses.
@chrisdp
chrisdp merged commit cec647d into master Jul 20, 2026
10 checks passed
@chrisdp
chrisdp deleted the fix/roku-deploy-loglevel-import branch July 20, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant