Fix compile break against roku-deploy 3.18#1752
Merged
Merged
Conversation
…gLevel'] instead of the deleted dist/Logger import roku-deploy 3.18.1 migrated to @rokucommunity/logger and deleted its internal Logger module, so the deep import of 'roku-deploy/dist/Logger' no longer resolves and every create-vsix build (which compiles brighterscript master against roku-deploy master) fails. Casting to RokuDeployOptions['logLevel'] tracks whatever type roku-deploy's options actually use, so this compiles against both roku-deploy 3.17.x and 3.18.x.
Delivers the large-upload EPIPE fix (rokucommunity/roku-deploy#324) and makes brighterscript's own CI compile and test against the same roku-deploy generation the create-vsix pipeline uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
roku-deploy 3.18.1 migrated to
@rokucommunity/logger(rokucommunity/roku-deploy#318) and deleted its internalLoggermodule.ProgramBuilder.tsdeep-imports that module:so brighterscript no longer compiles against roku-deploy >= 3.18. This currently breaks every create-vsix build in the org, since that pipeline compiles brighterscript master against roku-deploy master (first seen on rokucommunity/roku-debug#323).
Fix
logLevelcall sites toRokuDeployOptions['logLevel']instead. The indexed type tracks whatever roku-deploy's options actually declare, so it compiles against both roku-deploy 3.17.x (LogLevelfrom the old internal Logger) and 3.18.x (LogLevel | LogLevelNumericfrom@rokucommunity/logger). Verifiedtscis clean against both versions.@rokucommunity/loggerdedupes to a single 0.4.1 copy. Full test suite passes (2979 tests).