Security enhancements - #38
Merged
Merged
Conversation
brace-expansion, fast-uri, js-yaml, and uuid are pulled in exclusively through eslint/mocha/nyc/api-extractor (dev tooling), never shipped. No non-major version resolves them through normal resolution, so pin patched versions via overrides, same pattern already used for serialize-javascript. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
TwitchBronBron
added
the
Security enhancements
The flat "brace-expansion": "^5.0.9" override broke nyc's TypeScript instrumentation: minimatch@3.x/5.x (used by eslint and mocha/nyc's glob matching) call brace-expansion with the old 1.x/2.x calling convention, which brace-expansion@5 changed. nyc silently fell back to "return original code" for every file, producing an empty coverage report (caught by CI: Coveralls said "Nothing to report"). Fix: scope the override per consumer so each minimatch major line gets a brace-expansion version it's actually compatible with (eslint's minimatch@3.x -> brace-expansion@1.x, mocha's minimatch@5.x -> brace-expansion@2.x, api-extractor's minimatch@10.x -> brace-expansion@5.x). Verified locally: coverage is back to real 100% instead of "Unknown%". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
TwitchBronBron
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code