feat: add ogimage subcommand for OGP image generation from markdown - #159
Merged
Conversation
rokuosanai
added a commit
to rokuosanai/github-issue-cms
that referenced
this pull request
Jul 28, 2026
…uosan#159) - articleToOGPData: return zero-value OGPData when article is nil - resolveOGPOutputPath: return error when article is nil or Output config missing - Add filepath.Clean for path safety
rokuosanai
added a commit
to rokuosanai/github-issue-cms
that referenced
this pull request
Jul 28, 2026
…dit rokuosan#159) - Normalize Windows CRLF line endings to LF - Handle closing frontmatter delimiter at EOF (--- without trailing newline) - Add frontmatter prefix validation before parsing
- Add ParseArticleFromMarkdown to core package for reading Hugo-compatible markdown files with YAML frontmatter back into core.Article - Add 'ogimage' subcommand to CLI with -f/--file and -t/--template flags - Convert Article to OGPData and render via pkg/ogimage - Output ogp.jpeg into the configured image output directory - Register ogimage command in root CLI Closes rokuosan#154
…uosan#159) - articleToOGPData: return zero-value OGPData when article is nil - resolveOGPOutputPath: return error when article is nil or Output config missing - Add filepath.Clean for path safety
…dit rokuosan#159) - Normalize Windows CRLF line endings to LF - Handle closing frontmatter delimiter at EOF (--- without trailing newline) - Add frontmatter prefix validation before parsing
rokuosanai
force-pushed
the
feat/ogimage-subcommand
branch
from
July 29, 2026 03:25
f34b969 to
ebb4393
Compare
Owner
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements milestone 2 of #21 — adds an
ogimagesubcommand that generates OGP images from local Hugo-compatible markdown files.Changes
pkg/core/article_parser.go—ParseArticleFromMarkdown()function to read Hugo-compatible markdown (YAML frontmatter) back intocore.Articlecmd/cli/subcommand/ogimage.go— Newogimagesubcommand with:-f/--fileflag for markdown file path (required)-t/--templateflag for custom OGP HTML template (optional)Article→OGPData→ rendered JPEGogp.jpegin configured image output directorycmd/cli/cli.go— Registerogimagesubcommand in root CLIDepends on
Closes #154