fix(exports): scope inlined dependencies to configs with exports - #1040
Merged
Conversation
✅ Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
sxzz
requested changes
Jul 30, 2026
sxzz
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When several build configs share one
package.jsonand only some enableexports, the generatedinlinedDependenciesfield pulled inlined deps from every config for that package, including ones that never contribute to the exports map. So a config that bundles everything (say a standalone binary excluded fromfiles) leaked its inlined packages into the library's publishedpackage.json, even though the library externalizes those same packages.The fix scopes the merge to the bundles the exports map is built from, so
inlinedDependenciesonly lists deps that an exports config actually inlines.Linked Issues
Fixes #1039
Additional context
Added a regression test with a two-config setup (one library config with
exports, one bundle-everything config without) asserting the inlined dep from the second no longer appears in the package'sinlinedDependencies.