chore: drop unused sha3 dep (supersedes #24)#25
Merged
Conversation
The sha3 crate has been declared in both Cargo.toml files since the upstream SputnikVM fork, but is not actually used: SHA3 opcode handling in runtime/src/eval/system.rs delegates to Handler::keccak256_h256(), not sha3::Keccak256. The crate is not re-exported by lib.rs, and grepping rome-evm-private/rome-sdk/rome-apps confirms no downstream consumer pulls it through the evm crate. Dropping the dep cleanly resolves dependabot #24 (sha3 0.8 → 0.11), which fails because sha3 0.10+ removed the `std` feature flag that both Cargo.toml files reference under their `std` feature. Verified: - RUSTFLAGS=-Aunexpected_cfgs cargo build --release — succeeds - RUSTFLAGS=-Aunexpected_cfgs cargo clippy — clean - RUSTFLAGS=-Aunexpected_cfgs cargo test — 0 tests (none defined) - rome-evm-private/rome-sdk/rome-apps grep — no direct sha3 imports through the evm crate, so no downstream rebuild needed Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The `sha3` crate has been declared in both `Cargo.toml` and `runtime/Cargo.toml` since the upstream SputnikVM fork, but is not actually used:
Why this PR (vs dependabot #24)
Dependabot #24 tries to bump `sha3 0.8 → 0.11`. That fails CI because `sha3 0.10+` removed the `std` feature flag that both `Cargo.toml` files reference under their own `std` feature. Rather than reproduce a dead dep with a different version pin, this PR removes it.
Test plan
🤖 This response was generated by Claude Code.