Update sha3 requirement from 0.8 to 0.11#24
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Updates the requirements on [sha3](https://github.com/RustCrypto/hashes) to permit the latest version. - [Commits](RustCrypto/hashes@groestl-v0.8.0...sha3-v0.10.9) --- updated-dependencies: - dependency-name: sha3 dependency-version: 0.10.9 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/cargo/sha3-0.11
branch
from
fd6fb46 to
cc0f8ad
Compare
The sha3 crate has been declared in both Cargo.toml files since the upstream SputnikVM fork, but is not actually used: SHA3 opcode handling in runtime/src/eval/system.rs delegates to Handler::keccak256_h256(), not sha3::Keccak256. The crate is not re-exported by lib.rs, and grepping rome-evm-private/rome-sdk/rome-apps confirms no downstream consumer pulls it through the evm crate. Dropping the dep cleanly resolves dependabot #24 (sha3 0.8 → 0.11), which fails because sha3 0.10+ removed the `std` feature flag that both Cargo.toml files reference under their `std` feature. Verified: - RUSTFLAGS=-Aunexpected_cfgs cargo build --release — succeeds - RUSTFLAGS=-Aunexpected_cfgs cargo clippy — clean - RUSTFLAGS=-Aunexpected_cfgs cargo test — 0 tests (none defined) - rome-evm-private/rome-sdk/rome-apps grep — no direct sha3 imports through the evm crate, so no downstream rebuild needed Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Superseded by #25, which removed the unused sha3 dep entirely instead of bumping it (the crate has been dead code in this fork since SputnikVM days; SHA3 opcode handling delegates to Handler::keccak256_h256()). 🤖 This response was generated by Claude Code. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
1 participant
Updates the requirements on sha3 to permit the latest version.
Commits
1637e89Release sha3 v0.10.9 (#837)1997abesha3: backport fix of customized cshake initialization (#836)82c36a4sha2: add soft-compact backend (backport of #686) (#687)c1e85aeci: remove pre-1.56 jobs and other fixes (#688)a667dd9skein: fix implementation for output sizes not multiple of 8 (#682)62b6ff1Fix blake2 and ascon-hash CI (#521)f3b657cExpose belt_compress to public (#520)9f66cb8md4: Optimize compress to improve hash performance (#519)70a2b62Add simpler code snippet to the documentation (#515)e3ab257Update Cargo.lock