Skip to content

[ntuple] Fix decodeZigzag64 for SplitInt64 columns#410

Merged
linev merged 1 commit into
root-project:devfrom
undefined-panda:fix-decodeZigzag64
Jul 24, 2026
Merged

[ntuple] Fix decodeZigzag64 for SplitInt64 columns#410
linev merged 1 commit into
root-project:devfrom
undefined-panda:fix-decodeZigzag64

Conversation

@undefined-panda

Copy link
Copy Markdown
Contributor

DataView has no getUint64 or setInt64 methods, so reading a
SplitInt64 column raised a TypeError. Use the BigInt variants
getBigUint64 and setBigInt64.

@linev
linev changed the base branch from master to dev July 24, 2026 10:29
@linev
linev self-requested a review July 24, 2026 10:29
@linev linev self-assigned this Jul 24, 2026
@linev linev added the bug fix label Jul 24, 2026
@linev

linev commented Jul 24, 2026

Copy link
Copy Markdown
Member

Thanks for fixing it.
Did you observer bug with real file?

@linev
linev merged commit 7915641 into root-project:dev Jul 24, 2026
18 checks passed
@undefined-panda

undefined-panda commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Yes, I used a file which is created by the validation suite of ROOT. The SplitInt64 field raised an error in decodeZigZag64. Additionally, to avoid precision loss for BigInt entries, I had to remove Number() in rntuple.mjs line 909 and 917.

Both the .root and .mjs file used are in the zip-folder:
read_integer.zip

@linev

linev commented Jul 24, 2026

Copy link
Copy Markdown
Member

Conversion into number in lines 909 and 917 done because of limitation in TTree drawing functionality in JSROOT.
Before I can remove this conversion one need to resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants